Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote abstol and reltol type to match eltype(A) #397

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

ma-sadeghi
Copy link
Contributor

Fixes #396

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #397 (4c77e2c) into main (f4f6940) will decrease coverage by 0.93%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #397      +/-   ##
==========================================
- Coverage   68.97%   68.04%   -0.93%     
==========================================
  Files          26       26              
  Lines        1905     1906       +1     
==========================================
- Hits         1314     1297      -17     
- Misses        591      609      +18     
Files Coverage Δ
src/common.jl 89.28% <100.00%> (-1.46%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/common.jl Outdated Show resolved Hide resolved
@ma-sadeghi
Copy link
Contributor Author

ma-sadeghi commented Oct 20, 2023

@ChrisRackauckas Should we change here as well? (to prob.b)

abstol = default_tol(eltype(prob.A)),
reltol = default_tol(eltype(prob.A)),

@ChrisRackauckas
Copy link
Member

yes that would be good to change.

@ChrisRackauckas ChrisRackauckas merged commit 3f879bd into SciML:main Oct 20, 2023
12 of 19 checks passed
@amontoison
Copy link
Contributor

amontoison commented Oct 23, 2023

It will not work if the linear systems have complex numbers. You need real(eltype(b)) here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promote abstol and reltol type to match eltype(A)
3 participants