Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unnecessary < 1.9 checks #439

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Dec 4, 2023

No description provided.

@avik-pal avik-pal force-pushed the ap/remove_pre1.9 branch 2 times, most recently from 8644f32 to dcfb6cd Compare December 4, 2023 22:16
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (e712202) 64.10% compared to head (97ff64b) 66.31%.

Files Patch % Lines
src/factorization.jl 86.79% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #439      +/-   ##
==========================================
+ Coverage   64.10%   66.31%   +2.21%     
==========================================
  Files          27       27              
  Lines        2106     2019      -87     
==========================================
- Hits         1350     1339      -11     
+ Misses        756      680      -76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal
Copy link
Member Author

avik-pal commented Dec 5, 2023

@ChrisRackauckas this is good to go

@ChrisRackauckas ChrisRackauckas merged commit 9787717 into SciML:main Dec 6, 2023
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants