Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Interface boundary conditions #193

Merged
merged 25 commits into from
Nov 28, 2022
Merged

Allow Interface boundary conditions #193

merged 25 commits into from
Nov 28, 2022

Conversation

xtalax
Copy link
Member

@xtalax xtalax commented Nov 15, 2022

Allow connecting 2 variables together in bcs, if they have the same dimensionality and a similar argument signature, differing in no or one variable.

This only works for connecting the lower of one variable to the upper of another

Supersedes Periodic conditions

fixes #32
fixes #202

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #193 (5083def) into master (f449ba1) will decrease coverage by 5.42%.
The diff coverage is 67.97%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
- Coverage   80.47%   75.05%   -5.43%     
==========================================
  Files          35       37       +2     
  Lines        1685     1840     +155     
==========================================
+ Hits         1356     1381      +25     
- Misses        329      459     +130     
Impacted Files Coverage Δ
src/MOL_utils.jl 64.24% <ø> (-2.43%) ⬇️
src/interface/solution/plot_utils.jl 0.00% <0.00%> (ø)
src/system_parsing/pde_system_transformation.jl 40.74% <16.66%> (+0.61%) ⬆️
src/MOL_discretization.jl 63.39% <54.54%> (-12.76%) ⬇️
src/discretization/generate_bc_eqs.jl 68.20% <60.60%> (-14.76%) ⬇️
src/system_parsing/bcs/parse_boundaries.jl 81.53% <72.60%> (-17.38%) ⬇️
src/discretization/interface_boundary.jl 73.13% <73.13%> (ø)
src/discretization/schemes/WENO/WENO.jl 89.47% <85.71%> (-3.51%) ⬇️
...ion/schemes/upwind_difference/upwind_difference.jl 84.05% <86.66%> (-4.18%) ⬇️
...schemes/spherical_laplacian/spherical_laplacian.jl 92.30% <87.50%> (ø)
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xtalax xtalax merged commit 545fb9d into SciML:master Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught boundaries appearing in equations case Variables in separate but overlapping domains
1 participant