Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use abstractodesolution to allow sol = solve(prob) #195

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

anandijain
Copy link
Contributor

not sure if tests will pass, but this allows me to solve without an alg

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #195 (d47145b) into master (ee309fb) will increase coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage   80.30%   80.47%   +0.16%     
==========================================
  Files          35       35              
  Lines        1681     1685       +4     
==========================================
+ Hits         1350     1356       +6     
+ Misses        331      329       -2     
Impacted Files Coverage Δ
src/interface/solution/timedep.jl 85.29% <100.00%> (ø)
src/discretization/discretize_vars.jl 86.36% <0.00%> (-0.55%) ⬇️
src/interface/solution/solution_utils.jl 100.00% <0.00%> (+21.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xtalax
Copy link
Member

xtalax commented Nov 19, 2022

Looks good, thanks! Congrats on the first PR that adds functionality by someone who isn't me (since DEO)!

@xtalax xtalax merged commit 83f93ef into SciML:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants