Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test dependencies from the dependencies list #201

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #201 (5d71f91) into master (ff2cef1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   80.47%   80.47%           
=======================================
  Files          35       35           
  Lines        1685     1685           
=======================================
  Hits         1356     1356           
  Misses        329      329           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bowenszhu bowenszhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project.toml Outdated
@@ -12,16 +12,13 @@ Interpolations = "a98d9a8b-a2ab-59e6-89dd-64a1c18fca59"
Latexify = "23fbe1c1-3f47-55db-b15f-69d7ec21a316"
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78"
NonlinearSolve = "8913a72c-1f9b-4ce2-8d82-65094dcecaec"
OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed"
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And SafeTestsets should also be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep definitely thanks.

@ChrisRackauckas
Copy link
Member Author

Probably, but I'm behind on a few things and this is quicker so it's at least a fix for now. Getting the new NonlinearSolve out there and getting the enum handling fixes all done ASAP so I can get back to other things is my main priority, and then @xtalax can handle whatever else from there.

@xtalax
Copy link
Member

xtalax commented Nov 24, 2022

Sure, I've seen this now - I had thought that there should be a way to have testing dependencies separated but didn't know how to go about doing it, so thanks.

What actions do I need to take after this is merged? Follow the guide?

@ChrisRackauckas ChrisRackauckas merged commit acef497 into master Nov 24, 2022
@ChrisRackauckas ChrisRackauckas deleted the ChrisRackauckas-patch-1 branch November 24, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants