Merge pull request #1946 from SciML/bgc/sparsitycode

fixed sparsity bug
SciML · Nov 15, 2022 · 5d99e9c · 5d99e9c
2 parents 6244d2e + 29a6bf5
commit 5d99e9c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/systems/diffeqs/abstractodesystem.jl b/src/systems/diffeqs/abstractodesystem.jl
@@ -562,7 +562,7 @@ function ODEFunctionExpr{iip}(sys::AbstractODESystem, dvs = states(sys),
                           syms = $(Symbol.(states(sys))),
                           indepsym = $(QuoteNode(Symbol(get_iv(sys)))),
                           paramsyms = $(Symbol.(parameters(sys))),
-                          sparsity = $sparsity ? $(jacobian_sparsity(sys)) : $nothing)
+                          sparsity = $(sparsity ? jacobian_sparsity(sys) : nothing))
     end
     !linenumbers ? striplines(ex) : ex
 end

diff --git a/test/odesystem.jl b/test/odesystem.jl
@@ -82,6 +82,13 @@ f.f(du, u, p, 0.1)
 @test du == [4, 0, -16]
 @test_throws ArgumentError f.f(u, p, 0.1)
 
+#check sparsity
+f = eval(ODEFunctionExpr(de, [x, y, z], [σ, ρ, β], sparsity = true))
+@test f.sparsity == ModelingToolkit.jacobian_sparsity(de)
+
+f = eval(ODEFunctionExpr(de, [x, y, z], [σ, ρ, β], sparsity = false))
+@test isnothing(f.sparsity)
+
 eqs = [D(x) ~ σ * (y - x),
     D(y) ~ x * (ρ - z) - y * t,
     D(z) ~ x * y - β * z * κ]