-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Treating states properly, second encounter #605
Comments
I think that's reasonable. This was special cased before Chain could do that, and now that it can, we should aggressively simplify the code and interface. |
It was a bad idea to wrap them in a new |
I guess simply putting |
Moved to #687 |
I just realized that the recent PR #604 did not fix anything. As
Phi
is a mutable field of immutablePhysicsInformedNN
. The related source code is a bit messy. Adapting states should be done insidePhysicsInformedNN
. But there are too many situations to deal with and I don't want to fix it right away. For me, I just want to assume that the inputchain
is always aLux.Chain
, not vectors. If there are multiple dependent variables, then wrap them with another Chain, likeChain(u = chain_u, v = chain_v)
. We can usekeys(chain)==depvars
to check if there are multiple outputs. The advantage of doing this is that we can initialize the parameters and states at once. Thendiscretization.Phi
should probably be a named tuple so we don't need to remember the order of dependent variables.The text was updated successfully, but these errors were encountered: