Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes from final reviews, improved Docs #741

Merged
merged 10 commits into from
Oct 5, 2023

Conversation

AstitvaAggarwal
Copy link
Contributor

@AstitvaAggarwal AstitvaAggarwal commented Sep 27, 2023

fixes #737

@AstitvaAggarwal AstitvaAggarwal marked this pull request as draft September 27, 2023 10:57
@AstitvaAggarwal AstitvaAggarwal marked this pull request as ready for review September 27, 2023 20:07
@AstitvaAggarwal AstitvaAggarwal changed the title changes from final reviews changes from final reviews, improved Docs Sep 28, 2023
@AstitvaAggarwal
Copy link
Contributor Author

AstitvaAggarwal commented Sep 28, 2023

@xtalax @Vaibhavdixit02 this can be merged once checks pass.

src/BPINN_ode.jl Outdated Show resolved Hide resolved
src/BPINN_ode.jl Outdated Show resolved Hide resolved
@xtalax
Copy link
Member

xtalax commented Oct 4, 2023

passing, lgtm @Vaibhavdixit02 do you agree?

@Vaibhavdixit02
Copy link
Member

Lgtm 👍

@Vaibhavdixit02 Vaibhavdixit02 merged commit 00cc7f5 into SciML:master Oct 5, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix NUTS kwargs handling and Default ode params vector
3 participants