Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable precompilation #88

Merged
merged 1 commit into from
Feb 22, 2016
Merged

Conversation

jgoldfar
Copy link
Contributor

No description provided.

@ViralBShah
Copy link
Contributor

@tkelman Is this still the preferred way to do the precompliation?

@tkelman
Copy link
Contributor

tkelman commented Feb 20, 2016

Either this or isdefined(Base, :__precompile__)

Using isdefined has the benefit that it would work on NO_GIT builds of older 0.4-dev where version numbers are not accurate, but that's probably a rare case.

@acroy
Copy link
Contributor

acroy commented Feb 21, 2016

Certainly nice to have! I don't have a strong preference, which version we should use, but Tony's looks more elegant ...

@jgoldfar
Copy link
Contributor Author

Good to know; I'll update the PR. I would note that Compat.jl does it this way, so it may be worth updating that as well

@tomasaschan
Copy link
Contributor

isdefined has the added benefit of being forwards compatible, in case the mechanism for precompilation is changed in a future version of Julia (at least in the sense that nothing will throw errors; precompilation will silently break, but that won't make the package unusable).

@jgoldfar
Copy link
Contributor Author

Test for when to enable precompilation is now updated.

ViralBShah added a commit that referenced this pull request Feb 22, 2016
@ViralBShah ViralBShah merged commit f89d5f3 into SciML:master Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants