Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Stats and State #652

Merged
merged 17 commits into from Jan 5, 2024
Merged

[WIP]Stats and State #652

merged 17 commits into from Jan 5, 2024

Conversation

Vaibhavdixit02
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (80d8465) 8.46% compared to head (c0e59f6) 8.70%.

❗ Current head c0e59f6 differs from pull request most recent head abfa548. Consider uploading reports for the commit abfa548 to get more accurate results

Files Patch % Lines
lib/OptimizationFlux/src/OptimizationFlux.jl 0.00% 7 Missing ⚠️
...onStrategy/src/OptimizationCMAEvolutionStrategy.jl 0.00% 6 Missing ⚠️
lib/OptimizationBBO/src/OptimizationBBO.jl 0.00% 5 Missing ⚠️
...zationEvolutionary/src/OptimizationEvolutionary.jl 0.00% 4 Missing ⚠️
lib/OptimizationMOI/src/nlp.jl 0.00% 4 Missing ⚠️
lib/OptimizationOptimJL/src/OptimizationOptimJL.jl 63.63% 4 Missing ⚠️
lib/OptimizationNLopt/src/OptimizationNLopt.jl 0.00% 3 Missing ⚠️
lib/OptimizationGCMAES/src/OptimizationGCMAES.jl 0.00% 2 Missing ⚠️
...mization/src/OptimizationMultistartOptimization.jl 0.00% 2 Missing ⚠️
lib/OptimizationMOI/src/moi.jl 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #652      +/-   ##
=========================================
+ Coverage    8.46%   8.70%   +0.24%     
=========================================
  Files          30      31       +1     
  Lines        2470    2504      +34     
=========================================
+ Hits          209     218       +9     
- Misses       2261    2286      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas
Copy link
Member

Maybe it's time for a new design of the arguments list?

Project.toml Outdated Show resolved Hide resolved
@Vaibhavdixit02 Vaibhavdixit02 merged commit 880fc54 into master Jan 5, 2024
15 of 27 checks passed
@Vaibhavdixit02 Vaibhavdixit02 deleted the Vaibhavdixit02-patch-4 branch January 5, 2024 07:35
@sethaxen
Copy link
Contributor

sethaxen commented Jan 6, 2024

@Vaibhavdixit02 The changes to most of the integration packages are marked as breaking, but there's no description for me to know whether it is safe to upgrade. Would it be possible to summarize what this PR does and in what way it is breaking?

@Vaibhavdixit02
Copy link
Member Author

@sethaxen sure, it was breaking because the callback arguments have changed, instead of the optimization variables as the first argument now it will be a OptimizationState object. I have updated most of the docstring and am working on getting the examples updated, I am trying to get it done by this weekend!

@sethaxen
Copy link
Contributor

sethaxen commented Jan 6, 2024

Thanks, @Vaibhavdixit02 !

@ChrisRackauckas
Copy link
Member

We need to add a note on the README

@oscardssmith
Copy link

Since this was a breaking change, shouldn't this have required a major version bump?

@ChrisRackauckas
Copy link
Member

It did get a major IIRC

@SebastianM-C
Copy link
Contributor

Optimization.jl didn't get a major version bump, but the backends did get a minor bump (since they are 0.x).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants