refactor: remove type-pirated functions #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
=========================================
- Coverage 8.62% 8.53% -0.10%
=========================================
Files 31 31
Lines 2515 2496 -19
=========================================
- Hits 217 213 -4
+ Misses 2298 2283 -15 ☔ View full report in Codecov by Sentry. |
5 tasks
|
downgrade tests are failing: needs a bump? |
|
Yeah it should be bounded to 2.23.0 with this PR. Ref #692 |
moved to SciMLBase
AayushSabharwal
force-pushed
the
as/type-piracy
branch
2 times, most recently
from
22d8fe0
to
c17b3b9
Compare
AayushSabharwal
force-pushed
the
as/type-piracy
branch
from
c17b3b9
to
402b347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved to SciMLBase
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.