Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic DAE Initialization #1037

Merged
merged 9 commits into from Feb 18, 2020
Merged

Basic DAE Initialization #1037

merged 9 commits into from Feb 18, 2020

Conversation

kanav99
Copy link
Contributor

@kanav99 kanav99 commented Feb 17, 2020

https://cse.cs.ucsb.edu/sites/default/files/publications/SCE001495.pdf

Using NLsolve right now, I will try to remove that out

src/solve.jl Outdated Show resolved Hide resolved
@ChrisRackauckas
Copy link
Member

Needs a test.

@coveralls
Copy link

coveralls commented Feb 17, 2020

Coverage Status

Coverage increased (+0.008%) to 77.406% when pulling 0398974 on daeinit into e96a97f on master.

@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #1037 into master will decrease coverage by 18.84%.
The diff coverage is 53.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1037       +/-   ##
===========================================
- Coverage   76.78%   57.93%   -18.85%     
===========================================
  Files          94       95        +1     
  Lines       30571    30252      -319     
===========================================
- Hits        23475    17528     -5947     
- Misses       7096    12724     +5628
Impacted Files Coverage Δ
src/OrdinaryDiffEq.jl 100% <ø> (ø) ⬆️
src/caches/dae_caches.jl 86.2% <100%> (ø) ⬆️
src/solve.jl 89.24% <100%> (-2.64%) ⬇️
src/initialize_dae.jl 43.75% <43.75%> (ø)
src/tableaus/rkc_tableaus.jl 0% <0%> (-100%) ⬇️
src/caches/low_storage_rk_caches.jl 12.27% <0%> (-85.79%) ⬇️
src/caches/ssprk_caches.jl 13.38% <0%> (-81.4%) ⬇️
src/caches/rkc_caches.jl 22.5% <0%> (-74.28%) ⬇️
src/perform_step/rkc_perform_step.jl 15.2% <0%> (-70.4%) ⬇️
src/perform_step/low_storage_rk_perform_step.jl 23.79% <0%> (-68.47%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e96a97f...0398974. Read the comment docs.

@kanav99
Copy link
Contributor Author

kanav99 commented Feb 18, 2020

Added some basic test. There is a failing test (non index 1 DAE), that means we know whats missing. I guess we need an interface to define what all is known to the user, and what all the user wants us to initialize

@ChrisRackauckas
Copy link
Member

I guess we need an interface to define what all is known to the user, and what all the user wants us to initialize

That can come from the initialization method choice?

@@ -382,6 +383,9 @@ function DiffEqBase.__init(prob::Union{DiffEqBase.AbstractODEProblem,DiffEqBase.
isout,reeval_fsal,
u_modified,opts,destats)
if initialize_integrator
if isdae
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evaluate to see if initialization is required first? Or do that in initialize?

@ChrisRackauckas ChrisRackauckas marked this pull request as ready for review February 18, 2020 15:36
@ChrisRackauckas ChrisRackauckas merged commit c6c58cf into master Feb 18, 2020
@ChrisRackauckas ChrisRackauckas deleted the daeinit branch February 18, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants