Chunk size 1 when eltype is already dual #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YingboMa
reviewed
Dec 11, 2021
src/alg_utils.jl
Outdated
| @@ -181,12 +182,6 @@ function DiffEqBase.prepare_alg(alg::Union{OrdinaryDiffEqAdaptiveImplicitAlgorit | |||
| end | |||
| end | |||
| end | |||
| function DiffEqBase.prepare_alg(alg::Union{OrdinaryDiffEqAdaptiveImplicitAlgorithm{0,AD,FDT}, | |||
There was a problem hiding this comment.
I decided to change the approach to not set chunk size 1 for small enough duals.
|
Need to exclude or fix the extrapolation methods. |
Done. |
|
Looks like a real test failure: https://github.com/SciML/OrdinaryDiffEq.jl/runs/4498861629?check_suite_focus=true#step:6:499 |
|
Only remaining failure Non-diagonal SDE Tests | 2 2
└ @ SciMLBase ~/.julia/packages/SciMLBase/OpCVa/src/integrator_interface.jl:345
61.386006 seconds (108.90 M allocations: 6.584 GiB, 3.04% gc time, 97.67% compilation time)
┌ Warning: Instability detected. Aborting
└ @ SciMLBase ~/.julia/packages/SciMLBase/OpCVa/src/integrator_interface.jl:351
No Index Tests: Test Failed at /buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.7/Test/src/Test.jl:806
Expression: isempty(stderr_content)
Evaluated: isempty("┌ Warning: Instability detected. Aborting\n└ @ SciMLBase ~/.julia/packages/SciMLBase/OpCVa/src/integrator_interface.jl:351\n")
Stacktrace:
[1] macro expansion
@ /opt/hostedtoolcache/julia/1.7.0/x64/share/julia/stdlib/v1.7/Test/src/Test.jl:445 [inlined]
[2] top-level scope
@ ~/work/OrdinaryDiffEq.jl/OrdinaryDiffEq.jl/downstream/test/noindex_tests.jl:48
Test Summary: | Pass Fail Total
No Index Tests | 5 1 6 |
|
Ignore that. It's part of SciML/StochasticDiffEq.jl#445 |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would probably be worth actually running a variety of benchmarks here and picking between strategies.
For now, I'm setting the chunk size to
1ifsizeof(eltype(u0)) > 24, which would (for example) mean the element type are duals ofFloat64with 3 or more partials.Pumas hasn't been eager to merge any of the chunk size PRs as they cause a few regressions when applied globally.
But we can apply it more selectively here when choosing the chunk size as a function of the eltype.