-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support NonlinearSolve.jl for the ODE nonlinear solver #2167
Support NonlinearSolve.jl for the ODE nonlinear solver #2167
Conversation
so the current status is that out of place solves now work (although something is going wrong since it is getting a lot of nonlinear solver convergence failures). In place is broken because |
How does the default newton in ordinarydiffeq handle this?
you probably need the |
with |
it is worth mentioning that it is very possible that the better stats come from me not updating the stats properly. Still needs testing. |
8fe633e
to
5e3a91e
Compare
955f354
to
1729083
Compare
It's missing tests? |
4eb5ac4
to
33595bd
Compare
I've added some tests that use this. I'm not sure how much needs testing. |
Match a bit of what NLAnderson has done https://github.com/search?q=repo%3ASciML%2FOrdinaryDiffEq.jl+NLAnderson&type=code |
Are we using the jacobian reuse here? or is that a plan for later |
87da135
to
8ec1a02
Compare
363be86
to
7b3da65
Compare
I believe everything should now work. The last issues were that tstep and invγdt were being computed correctly, but the incorrect values for them were being passed into the nlp_params, leading to all sorts of nonsense. |
This is WIP, but it mostly works (for in place ODE only), (and is a lot slower since it's missing all the fancy optimizations still).