Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLsolve update #217

Merged
merged 3 commits into from
Nov 2, 2017
Merged

NLsolve update #217

merged 3 commits into from
Nov 2, 2017

Conversation

devmotion
Copy link
Member

This PR makes use of the new NLsolve release which allows AbstractArray instead of Vector. I could simplify caches of all methods that use NLSOLVEJL_SETUP, i.e. of GenericImplicitEuler, GenericImplicitTrapezoid, GenericIIF1, and GenericIIF2. Moreover, the proposed changes supersede the definition of NLSOLVEJL_SETUP in DiffEqCallbacks and hence supersede also SciML/DiffEqCallbacks.jl#17.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 76.734% when pulling 36f7603 on devmotion:nlsolve into 822ae90 on JuliaDiffEq:master.

@ChrisRackauckas ChrisRackauckas merged commit a2e129e into SciML:master Nov 2, 2017
@codecov
Copy link

codecov bot commented Nov 2, 2017

Codecov Report

Merging #217 into master will increase coverage by 0.01%.
The diff coverage is 66.1%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   76.71%   76.73%   +0.01%     
==========================================
  Files          61       61              
  Lines       21444    21430      -14     
==========================================
- Hits        16451    16444       -7     
+ Misses       4993     4986       -7
Impacted Files Coverage Δ
src/integrators/iif_integrators.jl 0% <0%> (ø) ⬆️
src/caches/linear_nonlinear_caches.jl 0% <0%> (ø) ⬆️
src/integrators/generic_implicit_integrators.jl 95.37% <100%> (-0.03%) ⬇️
src/integrators/integrator_interface.jl 71.21% <100%> (-0.85%) ⬇️
src/caches/generic_implicit_caches.jl 94.73% <100%> (-0.62%) ⬇️
src/misc_utils.jl 77.27% <100%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 822ae90...36f7603. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants