Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change save_start to take saveat into consideration #429

Merged
merged 2 commits into from
Jul 13, 2018

Conversation

Vaibhavdixit02
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jul 12, 2018

Coverage Status

Coverage increased (+38.4%) to 65.126% when pulling 29aeafc on Vaibhavdixit02:save_start into cf20288 on JuliaDiffEq:master.

@ChrisRackauckas
Copy link
Member

Need to check this test to see if it's the desired behavior: https://travis-ci.org/JuliaDiffEq/OrdinaryDiffEq.jl/jobs/403297358#L957-L1037

@codecov
Copy link

codecov bot commented Jul 13, 2018

Codecov Report

Merging #429 into master will decrease coverage by 4.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #429     +/-   ##
=========================================
- Coverage   47.47%   43.17%   -4.3%     
=========================================
  Files          78       78             
  Lines       23707    23682     -25     
=========================================
- Hits        11254    10225   -1029     
- Misses      12453    13457   +1004
Impacted Files Coverage Δ
src/solve.jl 71.36% <ø> (-15.5%) ⬇️
src/composite_algs.jl 0% <0%> (-100%) ⬇️
src/perform_step/composite_perform_step.jl 4.34% <0%> (-86.96%) ⬇️
src/composite_solution.jl 0% <0%> (-69.57%) ⬇️
src/iterator_interface.jl 0% <0%> (-46.67%) ⬇️
src/caches/sdirk_caches.jl 0% <0%> (-44.55%) ⬇️
src/perform_step/sdirk_perform_step.jl 0% <0%> (-35.06%) ⬇️
src/exponential_utils.jl 65.7% <0%> (-24.36%) ⬇️
src/nlsolve_utils.jl 80.95% <0%> (-19.05%) ⬇️
src/integrators/integrator_utils.jl 56.59% <0%> (-17.45%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf20288...29aeafc. Read the comment docs.

@ChrisRackauckas
Copy link
Member

I realized that this was a bit more intricate than I had at first thought and the best definition would be implementing the one in my head, so I went ahead and did that. We need to get all of the solver packages uniform to this though.

@ChrisRackauckas ChrisRackauckas merged commit 45611bc into SciML:master Jul 13, 2018
@ChrisRackauckas
Copy link
Member

Don't forget the PR to DiffEqBayes to remove the special handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants