Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dt handling #553

Merged
merged 1 commit into from
Nov 4, 2018
Merged

Refactor dt handling #553

merged 1 commit into from
Nov 4, 2018

Conversation

devmotion
Copy link
Member

Move dt handling to separate function, as suggested in SciML/DelayDiffEq.jl#88 (comment).

Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@ChrisRackauckas
Copy link
Member

Mwtp

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.001%) to 32.042% when pulling 5299cb8 on handle_dt into c20a103 on master.

@codecov
Copy link

codecov bot commented Nov 4, 2018

Codecov Report

Merging #553 into master will decrease coverage by <.01%.
The diff coverage is 30%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #553      +/-   ##
=========================================
- Coverage   33.51%   33.5%   -0.01%     
=========================================
  Files          81      81              
  Lines       23613   23614       +1     
=========================================
- Hits         7914    7912       -2     
- Misses      15699   15702       +3
Impacted Files Coverage Δ
src/solve.jl 46.26% <30%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c20a103...5299cb8. Read the comment docs.

@devmotion devmotion merged commit bd47c47 into master Nov 4, 2018
@devmotion devmotion deleted the handle_dt branch November 4, 2018 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants