-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Wfact when it is available #847
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using OrdinaryDiffEq, ModelingToolkit, Test
function lotka(du,u,p,t)
x = u[1]
y = u[2]
du[1] = p[1]*x - p[2]*x*y
du[2] = -p[3]*y + p[4]*x*y
end
prob = ODEProblem(lotka,[1.0,1.0],(0.0,1.0),[1.5,1.0,3.0,1.0])
de = ModelingToolkit.modelingtoolkitize(prob)
prob2 = remake(prob, f=ODEFunction(de..., Val(false), Wfact=true))
sol = solve(prob, KenCarp4())
@test Array( solve(prob2, Rodas5()) ) ≈ Array( solve(prob, Rodas5()) )
@test Array( solve(prob2, KenCarp4(), tstops=sol.t, adaptive=false) ) ≈ Array( solve(prob, KenCarp4(), tstops=sol.t, adaptive=false) ) julia> @test Array( solve(prob2, Rodas5()) ) ≈ Array( solve(prob, Rodas5()) )
Test Passed
julia> @test Array( solve(prob2, KenCarp4(), tstops=sol.t, adaptive=false) ) ≈ Array( solve(prob, KenCarp4(), tstops=sol.t, adaptive=false) )
Test Passed |
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
=========================================
- Coverage 80.35% 79.15% -1.2%
=========================================
Files 90 90
Lines 29846 29849 +3
=========================================
- Hits 23982 23628 -354
- Misses 5864 6221 +357
Continue to review full report at Codecov.
|
Waiting on JuliaNLSolvers/NLsolve.jl#220 I think. |
ChrisRackauckas
approved these changes
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on SciML/DiffEqBase.jl#303