-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upper bound DiffEqBase and ExponentialUtilities #891
Conversation
Past versions need the upper bound too. @StefanKarpinski what's the right way to do that with the new registry setup? |
Make a PR to the registry editing the Compat.toml files there by hand. |
Codecov Report
@@ Coverage Diff @@
## master #891 +/- ##
==========================================
- Coverage 80.09% 80.01% -0.08%
==========================================
Files 92 92
Lines 30411 30461 +50
==========================================
+ Hits 24357 24374 +17
- Misses 6054 6087 +33
Continue to review full report at Codecov.
|
Should we also drop support for old versions of StaticArrays and DataStructures? |
I think so. At whatever point they put the 1.0 we should go with that, but until then we just stay up to date. |
@ChrisRackauckas Good to merge now? |
Yes, but without editing the Compat.toml we cannot tag. |
Add semver compatible upper bounds for DiffEqBase and ExponentialUtilities (see https://julialang.github.io/Pkg.jl/v1/compatibility/#Version-specifier-format-1).
Should we do the same even for dependencies with 0.x version numbers? And should we update the registry for old releases?