Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upper bound DiffEqBase and ExponentialUtilities #891

Merged
merged 6 commits into from
Aug 23, 2019
Merged

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Aug 22, 2019

Add semver compatible upper bounds for DiffEqBase and ExponentialUtilities (see https://julialang.github.io/Pkg.jl/v1/compatibility/#Version-specifier-format-1).

Should we do the same even for dependencies with 0.x version numbers? And should we update the registry for old releases?

@ChrisRackauckas
Copy link
Member

Past versions need the upper bound too. @StefanKarpinski what's the right way to do that with the new registry setup?

@StefanKarpinski
Copy link

Make a PR to the registry editing the Compat.toml files there by hand.

@coveralls
Copy link

coveralls commented Aug 22, 2019

Coverage Status

Coverage increased (+0.06%) to 80.824% when pulling 4dc9e1a on upperbound into e46c08b on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.76% when pulling 8513811 on upperbound into e46c08b on master.

@codecov
Copy link

codecov bot commented Aug 23, 2019

Codecov Report

Merging #891 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #891      +/-   ##
==========================================
- Coverage   80.09%   80.01%   -0.08%     
==========================================
  Files          92       92              
  Lines       30411    30461      +50     
==========================================
+ Hits        24357    24374      +17     
- Misses       6054     6087      +33
Impacted Files Coverage Δ
src/solve.jl 72.88% <0%> (-19.6%) ⬇️
src/integrators/integrator_utils.jl 86.72% <0%> (+0.82%) ⬆️
src/caches/kencarp_kvaerno_caches.jl 97.02% <0%> (+0.99%) ⬆️
src/perform_step/sdirk_perform_step.jl 79.29% <0%> (+1.51%) ⬆️
src/dense/rosenbrock_interpolants.jl 94.59% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46c08b...4dc9e1a. Read the comment docs.

@devmotion
Copy link
Member Author

Should we also drop support for old versions of StaticArrays and DataStructures?

@ChrisRackauckas
Copy link
Member

I think so. At whatever point they put the 1.0 we should go with that, but until then we just stay up to date.

@devmotion
Copy link
Member Author

@ChrisRackauckas Good to merge now?

@ChrisRackauckas
Copy link
Member

Yes, but without editing the Compat.toml we cannot tag.

@ChrisRackauckas ChrisRackauckas merged commit c468815 into master Aug 23, 2019
@ChrisRackauckas ChrisRackauckas deleted the upperbound branch August 23, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants