Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KroneckerSample problems #34

Closed
ParadaCarleton opened this issue Oct 3, 2022 · 3 comments
Closed

KroneckerSample problems #34

ParadaCarleton opened this issue Oct 3, 2022 · 3 comments

Comments

@ParadaCarleton
Copy link
Collaborator

ParadaCarleton commented Oct 3, 2022 •
edited
Loading

I can't work out how KroneckerSample is supposed to work. I'm not sure whether this is because the docstring is extremely unclear, or if the code is actually broken.
@ParadaCarleton ParadaCarleton changed the title KroneckerSample docstring vague KroneckerSample problems Oct 3, 2022
@ChrisRackauckas
Copy link
Member

From #20 SciML/Surrogates.jl#125 @ludoro what was the reference for this one?

@ParadaCarleton
Copy link
Collaborator Author

@ChrisRackauckas from what I can tell the code is just completely broken/incorrect. The package might need a lot of rewriting 😅

@ChrisRackauckas
Copy link
Member

It does. And this time around, a lot more adding of references to the docstrings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @ParadaCarleton