Fix Kronecker sequences #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Oct 25, 2022
|
Run the formatter. using JuliaFormatter
format("path/to/repo") |
| end | ||
| GoldenSample() = GoldenSample(zero(Float64)) | ||
|
|
||
| function sample(n::Integer, d::Integer, g::GoldenSample{T}) where {T} |
There was a problem hiding this comment.
@ParadaCarleton it looks like these are missing the standard lb,ub dispatches?
There was a problem hiding this comment.
@ParadaCarleton it looks like these are missing the standard lb,ub dispatches?
Yes, it looks like it. I'll make a PR that creates a generic lb and ub method, so we don't have to rewrite a new one for every function and can just implement a generic sampler.
Is there a way to test downstream packages to make sure nothing breaks in the future?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.