Allow for setting the default specialization via Preferences #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
==========================================
- Coverage 53.98% 51.20% -2.79%
==========================================
Files 41 41
Lines 2949 2949
==========================================
- Hits 1592 1510 -82
- Misses 1357 1439 +82
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
devmotion
reviewed
Sep 15, 2022
Comment on lines
+9
to
+10
| const DEFAULT_SPECIALIZATION = Preferences.@load_preference("SpecializationLevel", | ||
| AutoSpecialize) |
There was a problem hiding this comment.
Does this actually work for non-default values? Can one load types from the TOML file? I assumed it would only support values that are supported by TOML, such as e.g. booleans, numbers, or strings.
There was a problem hiding this comment.
Oh interesting... I guess we'd need to parse the string into a type definition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.