Fix ambiguities

[SebastianM-C]

I removed the ::Function restriction as mentioned in #42 (comment)

[codecov]

Codecov Report

Merging #43 (069eaf9) into master (4a95d3d) will decrease coverage by 1.75%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master     #43      +/-   ##
=========================================
- Coverage   11.41%   9.66%   -1.76%     
=========================================
  Files          39      39              
  Lines        2829    2825       -4     
=========================================
- Hits          323     273      -50     
- Misses       2506    2552      +46     

Impacted Files	Coverage Δ
src/SciMLBase.jl	100.00% <ø> (ø)
src/problems/dde_problems.jl	0.00% <0.00%> (ø)
src/utils.jl	25.00% <0.00%> (-44.42%)	⬇️
src/remake.jl	37.50% <0.00%> (-6.50%)	⬇️
src/scimlfunctions.jl	6.79% <0.00%> (-1.11%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d67b76e...069eaf9. Read the comment docs.

[devmotion]

Maybe you could add a test of detect_ambiguities to avoid regressions and to ensure that no new ambiguities are added?

[SebastianM-C]

There already is one (it's the first test actually)

SciMLBase.jl/test/runtests.jl

Line 6 in 15df156

@test isempty(detect_ambiguities(SciMLBase))

[devmotion]

Oh OK, I didn't notice this, somehow I just assumed all tests pass on the master branch 😄

[devmotion]

LGTM 👍

[isaacsas]

FWIW the DiffEqJump downstream failure is a dumb test bug (there is apparently a RNG-dependent outcome for a test...).

[SebastianM-C]

@isaacsas Thanks, I was not sure what was the problem with that.