Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated indexing in EnsembleSummary plot recipe #604

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

SebastianM-C
Copy link
Contributor

I missed this ones.
@AayushSabharwal is this ok? It seems a bit odd to need sim.u.u[1] at first sight.

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (5d3ac43) 39.96% compared to head (d6bb6e2) 39.96%.

Files Patch % Lines
src/ensemble/ensemble_solutions.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   39.96%   39.96%           
=======================================
  Files          54       54           
  Lines        4076     4076           
=======================================
  Hits         1629     1629           
  Misses       2447     2447           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal
Copy link
Member

Yeah that is weird. VectorOfArrays shouldn't have a VectorOfArray as u. I'll investigate this further

@SebastianM-C
Copy link
Contributor Author

I'm not sure if it helps, but I was wondering if this is due to the fact that individual ODESolutions are no longer AbstractArrays and the recipes relied on this to distinguish between scalar and vector cases, as for ensemble you can have scalar differential equations or output functions that return scalars.

@AayushSabharwal
Copy link
Member

This does seem to be what is required here. I'm not fully on board with the AbstractVectorOfArray.u being another AbstractVectorOfArray thing that's going on, but if it works it works I guess.

@SebastianM-C
Copy link
Contributor Author

Should this be merged?

cc @ChrisRackauckas

@ChrisRackauckas ChrisRackauckas merged commit a97cbb0 into SciML:master Jan 30, 2024
33 of 41 checks passed
@SebastianM-C SebastianM-C deleted the ensemble2 branch January 30, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants