Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: remove mentions of SDESolution #683

Closed
wants to merge 8 commits into from

Conversation

DhairyaLGandhi
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

SDESolution doesn't seem to exist anymore. The more appropriate type seems to be RODESolution. This PR removes mentions of SDESolution and replaces them with RODESolution. Further, one of the adjoints was incorrect. It was definining an adjoint over SDEProblem, but instead tries returning SDESolution in the forwards pass. Not sure how this passed tests though

Add any other context about the problem here.

@AayushSabharwal
Copy link
Member

Could you add a test that differentiates through an SDEProblem solve? That way we can verify the new gradients work and ensure they continue to do so

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 31.64%. Comparing base (1238b2b) to head (ae40a6c).
Report is 11 commits behind head on master.

Files Patch % Lines
ext/SciMLBaseZygoteExt.jl 0.00% 19 Missing ⚠️
ext/SciMLBaseChainRulesCoreExt.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #683      +/-   ##
==========================================
- Coverage   31.72%   31.64%   -0.08%     
==========================================
  Files          55       55              
  Lines        4505     4519      +14     
==========================================
+ Hits         1429     1430       +1     
- Misses       3076     3089      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants