Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bio benchmarks #617

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Bump bio benchmarks #617

merged 1 commit into from
Aug 29, 2023

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

Copy link

@ai-maintainer ai-maintainer bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 

This pull request is too large for automated review.

Reviewed with AI Maintainer

@ChrisRackauckas
Copy link
Member Author

@TorkelE I'm bumping to see performance, but can you help with the Catalyst 13 update on these?

@TorkelE
Copy link
Member

TorkelE commented Aug 2, 2023

Sounds goo.d Yes, Iäll have a look tomorrow morning.

@TorkelE
Copy link
Member

TorkelE commented Aug 3, 2023

Just checking, exactly what should I do? I could update the Catalyst version to the latest ones in the Project.toml files? Since the models are all loaded from .net files I don't think that should change anything.

Should I modify this PR directly? I think the last couple of times I've tried stuff like this in git things usually got messed up, but might be a good learning opportunity. Is there someone in the office that might be able to show the proper workflow for this?

@ChrisRackauckas
Copy link
Member Author

Yeah just modify this PR.

@TorkelE
Copy link
Member

TorkelE commented Aug 7, 2023

I cannot make modifications to this PR directly (I think I'm not part of SciMLBenchmarks). I tried to make a PR to this PR: #622 Not sure if it worked out though

@ChrisRackauckas ChrisRackauckas merged commit 4948965 into master Aug 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants