Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the SciMLStructures Tunable interface #1010

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

ChrisRackauckas
Copy link
Member

This uses the SciMLStructures Tunable interface https://github.com/SciML/SciMLStructures.jl in order to allow more generalized definitions of p.

  • Ensure Lux.jl is well supported (componentarrays extension in SciMLStructures
  • Add a test for a custom SciMLStructure

This uses the SciMLStructures Tunable interface https://github.com/SciML/SciMLStructures.jl in order to allow more generalized definitions of `p`.

- [ ] Ensure Lux.jl is well supported (componentarrays extension in SciMLStructures
- [ ] Add a test for a custom SciMLStructure
@ArnoStrouwen
Copy link
Member

ArnoStrouwen commented Feb 8, 2024

You need to actually pass repack?

default_sensealg = automatic_sensealg_choice(prob, u0, p, verbose)

@ChrisRackauckas
Copy link
Member Author

Yeah this isn't quite done. We should do a branch of, if it's a mutable structure then we just use replace!(::AbstractPortion, p::T1, new_values), and only repack if it's immutable.

@ArnoStrouwen
Copy link
Member

ArnoStrouwen commented Feb 8, 2024

Something isn't completely clicking with me, how this change can be so simple.
Where is the logic living that when in the adjoint equations df/dp and dg/dp occurs, we should only take the tunable parameters?

@ChrisRackauckas
Copy link
Member Author

I should've marked WIP. Plan to finish it during today.

@xtalax
Copy link
Member

xtalax commented Feb 9, 2024

Can we expect this to be released by Monday?

@ChrisRackauckas
Copy link
Member Author

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants