Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix incorrect usage of getu resulting in flattened arrays #1076

Merged
merged 3 commits into from
Jul 5, 2024

Conversation

AayushSabharwal
Copy link
Member

This worked before due to an SII bug. SII 0.3.25 fixed this bug, and thus broke SciMLSensitivity. The compat for SII is updated to not include 0.3.25 because of the way SciMLFunction defined symbolic_container, which requires a fix in 0.3.26 to work properly.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas ChrisRackauckas merged commit 682c3ec into SciML:master Jul 5, 2024
14 of 16 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-getu branch July 5, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants