Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added check_error to atsit5 #53

Closed
wants to merge 1 commit into from

Conversation

rusandris
Copy link

The check_error for DEIntegrator doesn't work for the simple integrator types because they have different fields. I've added a simple function to handle atsit5 which is the default solver in DynamicalSystems.
See: Issue 184 at JuliaDynamics/DynamicalSystems.jl

@rusandris
Copy link
Author

I'm not sure if this is the right place to add this function. Would this check_error defined for simple integrator types and the one from SciMLBase collide?
Also, should I open an issue for this instead?

@ChrisRackauckas
Copy link
Member

Why not just use Tsit5? The purpose of the simplified version is that it cuts out pieces like this, and the error check is the vast majority of the overhead cut out. If this is added... we're basically back at Tsit5?

@rusandris
Copy link
Author

You mean changing the default to Tsit5? I don't think it would be a good idea to change the default just because of this. But yes, you are right, we thought that the error checking should work the same way for all types of integrators, but the best option indeed would be if we leave the simple integrators as they are, and use the error checking only in the other cases in our functions that use integrators.

@rusandris rusandris closed this Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants