CompatHelper: bump compat for DifferentiationInterface to 0.5, (keep existing compat) #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
===========================================
- Coverage 90.34% 71.22% -19.13%
===========================================
Files 21 21
Lines 1202 1199 -3
===========================================
- Hits 1086 854 -232
- Misses 116 345 +229 ☔ View full report in Codecov by Sentry. |
|
Superseded by #150, please close |
|
No, CompatHelpers cannot be closed until the compat fix is in. |
|
My bad, then of course wait until #150 is merged. It's a breaking change which I really want to have in SimpleNonlinearSolve before the indirect dependency on DI spreads everywhere |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
DifferentiationInterfacepackage from0.4to0.4, 0.5.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.