Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Mode overloads for Least Squares Problem #131

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Feb 26, 2024

This is just applying the implicit function theorem at the critical points

@avik-pal avik-pal marked this pull request as ready for review February 26, 2024 19:01
@avik-pal avik-pal changed the title Forward Mode overloads for Least Squares Problem [wip] Forward Mode overloads for Least Squares Problem Feb 26, 2024
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 90.90%. Comparing base (8995a23) to head (fe8f562).
Report is 3 commits behind head on main.

Files Patch % Lines
ext/SimpleNonlinearSolveZygoteExt.jl 25.00% 3 Missing ⚠️
src/ad.jl 94.91% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   90.26%   90.90%   +0.63%     
==========================================
  Files          20       21       +1     
  Lines        1223     1286      +63     
==========================================
+ Hits         1104     1169      +65     
+ Misses        119      117       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal changed the title [wip] Forward Mode overloads for Least Squares Problem Forward Mode overloads for Least Squares Problem Feb 26, 2024
@avik-pal avik-pal merged commit fd7d216 into SciML:main Feb 26, 2024
12 of 16 checks passed
@avik-pal avik-pal deleted the ap/nlls_adjoint branch February 26, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants