Improved Options for Termination Conditions #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah this looks mostly good. It would be good for that number 30 to be tweakable, and add some tests, and I think this is done. |
avik-pal
force-pushed
the
ap/termination
branch
from
b38f19b
to
2bb8526
Compare
avik-pal
commented
Feb 9, 2023
avik-pal
force-pushed
the
ap/termination
branch
from
2bb8526
to
fecfaaa
Compare
7 tasks
avik-pal
force-pushed
the
ap/termination
branch
from
fecfaaa
to
a4c2744
Compare
avik-pal
changed the title
| for mode in (:rel_safe, :rel_safe_best, :abs_safe, :abs_safe_best) | ||
| T = SteadyStateTerminationCriteria{mode} | ||
| mode_val = Val(mode) | ||
| @eval function _get_termination_condition(cond::$(T), storage) |
There was a problem hiding this comment.
do they need to be dispatches?
There was a problem hiding this comment.
It feels wrong to have something that is known at compile time and make them runtime branches 😅
There was a problem hiding this comment.
but is this improving runtime or just adding compile time?
There was a problem hiding this comment.
This particular set of @evals isn't adding any compile time. But the _has_converged ones add like 0.8ms over 3.6ms compilation time.
There was a problem hiding this comment.
I still think it's a hyperoptimization to make this all dispatch, but we can keep it for now.
avik-pal
force-pushed
the
ap/termination
branch
from
7dba623
to
d3e23c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.