Feature/add missing abstractions #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 48824e1 in 1 minute and 38 seconds
More details
- Looked at
476lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_gbFd2iDb64JCCGFD
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| ) | ||
| properties: Dict[str, Any] = Field(default_factory=dict) | ||
|
|
||
| @abstractmethod |
There was a problem hiding this comment.
The use of @abstractmethod in LabelledNode which inherits from BaseModel is incorrect because BaseModel does not support abstract methods. Consider using a different base class that supports abstract methods, such as ABC.
iCUE-Solutions
pushed a commit
to DeweyLearn/DeweyLearnR2R
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added new abstractions for handling graph data and updated
extract_entitiesto handle cases with more than two colons in the input string.Key points:
versioninpyproject.tomlto0.2.18.extract_entitiesinr2r/core/abstractions/document.pyto handle cases with more than two colons in the input string.r2r/core/abstractions/llama_abstractions.pywith abstractions for handling graph data, including classes likeLabelledNode,EntityNode,ChunkNode,Relation,VectorStoreQuery, andPropertyGraphStore.r2r/core/abstractions/llama_abstractions.pyfor vector store queries and metadata filtering.Generated with ❤️ by ellipsis.dev