Update quickstart.py #578
Merged
Update quickstart.py #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needs another dumb unpack, will fix
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7b3fb4c in 32 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_T6eRB0ZxQStCFeJL
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -595,7 +595,7 @@ def serve(self, host: str = "0.0.0.0", port: int = 8000): | |||
| self.app.serve(host, port) | |||
|
|
|||
| def get_app(self): | |||
| return self.app.app | |||
| return self.app.app.app | |||
There was a problem hiding this comment.
The change to self.app.app.app seems unusual. Please confirm if the app object structure has indeed changed to require triple nesting. If not, this could lead to runtime errors due to attribute access issues.
iCUE-Solutions
pushed a commit
to DeweyLearn/DeweyLearnR2R
that referenced
this pull request
Jul 18, 2024
needs another dumb unpack, will fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs another dumb unpack, will fix
Summary:
Updated
R2RQuickstart.get_appmethod inr2r/examples/quickstart.pyto returnself.app.app.appinstead ofself.app.app.Key points:
r2r/examples/quickstart.pyR2RQuickstart.get_appself.app.apptoself.app.app.appto ensure the correct application instance is returned.Generated with ❤️ by ellipsis.dev