integrate: Jafama + KMath #357

therealansh · 2021-06-02T19:49:30Z

This PR resolves #176.

kmath-jafama/build.gradle.kts

kmath-jafama/src/main/kotlin/space/kscience/kmath/jafama/CmnFastMath.java

kmath-jafama/src/main/kotlin/space/kscience/kmath/jafama/DoubleWrapper.java

kmath-jafama/src/main/kotlin/space/kscience/kmath/jafama/IntWrapper.java

kmath-jafama/src/main/kotlin/space/kscience/kmath/jafama/KMathJafama.kt

kmath-jafama/build.gradle.kts

kmath-jafama/src/main/kotlin/space/kscience/kmath/jafama/KMathJafama.kt

altavir · 2021-06-03T05:39:03Z

I've rebased the fork since we do not do merges directly to the master. Please resolve conflicts.

altavir · 2021-06-03T05:40:37Z

The module must be better documented (there should be a readme template). Also, there should be examples and a benchmark since the primary aim is performance.

therealansh · 2021-06-03T17:52:52Z

Hey @altavir @CommanderTvis
While running Benchmarks i am running into this problem

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/Users/anshtyagi/.gradle/caches/modules-2/files-2.1/org.openjdk.jmh/jmh-core/1.21/442447101f63074c61063858033fbfde8a076873/jmh-core-1.21.jar) to field java.io.PrintStream.charOut
WARNING: Please consider reporting this to the maintainers of org.openjdk.jmh.util.Utils
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
Exception in thread "main" java.lang.RuntimeException: ERROR: Unable to find the resource: /META-INF/BenchmarkList
	at org.openjdk.jmh.runner.AbstractResourceReader.getReaders(AbstractResourceReader.java:98)
	at org.openjdk.jmh.runner.BenchmarkList.find(BenchmarkList.java:122)
	at org.openjdk.jmh.runner.Runner.internalRun(Runner.java:263)
	at org.openjdk.jmh.runner.Runner.run(Runner.java:209)
	at org.openjdk.jmh.Main.main(Main.java:71)

Process finished with exit code 1

Any workaround to test benchmarks?

CommanderTvis · 2021-06-03T18:23:50Z

Use JDK 11. @therealansh

therealansh · 2021-06-04T04:58:59Z

Use JDK 11. @therealansh

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/Users/anshtyagi/.gradle/caches/modules-2/files-2.1/org.openjdk.jmh/jmh-core/1.21/442447101f63074c61063858033fbfde8a076873/jmh-core-1.21.jar) to field java.io.PrintStream.charOut

The issue does not seem to be resolved even after using JDK 11. I am using IntelliJ as IDE and have set the JDK to be 11

CommanderTvis · 2021-06-04T17:22:14Z

Use JDK 11. @therealansh
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.openjdk.jmh.util.Utils (file:/Users/anshtyagi/.gradle/caches/modules-2/files-2.1/org.openjdk.jmh/jmh-core/1.21/442447101f63074c61063858033fbfde8a076873/jmh-core-1.21.jar) to field java.io.PrintStream.charOut
The issue does not seem to be resolved even after using JDK 11. I am using IntelliJ as IDE and have set the JDK to be 11

Now it's a warning, and it's an issue to JMH and kotlinx-benchmark, which is already reported AFAIK.

CommanderTvis · 2021-06-05T15:35:26Z

@therealansh There are still some conflicts.

altavir

Benchmark and their results in README are still missing.

kmath-jafama/src/main/kotlin/space/kscience/kmath/jafama/KMathJafama.kt

altavir · 2021-06-06T06:20:13Z

kmath-jafama/src/main/kotlin/space/kscience/kmath/jafama/KMathJafama.kt

+
+    public override inline fun norm(arg: Double): Double = FastMath.abs(arg)
+
+    public override inline fun Double.unaryMinus(): Double = -this


Does not make sense to override those.

in basic arithmetic operations like these library functions are not even used should i just remove them instead?

As long as you implement basic add/multiply it should work. They are present in DoubleField for performance considerations, But I am not sure that they matter.

therealansh · 2021-06-06T12:36:08Z

Benchmark and their results in README are still missing.

As i stated the benchmarks written does not run due to the warning and thus does not produce any results. I'll be finding a work around for it.

altavir · 2021-06-06T12:39:24Z

@therealansh The warning is completely harmless. It should work perfectly fine with it. So your problem is with something else. Try looking into the benchmarks subproject and just replicate what happens there.

Not actual

altavir · 2021-06-07T16:46:22Z

Still no benchmarcs.

therealansh · 2021-06-08T04:12:29Z

Still no benchmarcs.

The issue is still persistant. The resource file META_INF/BenchmarksList seems to be missing and i have tried the solutions but nothing seems to work

altavir · 2021-06-08T05:14:10Z

I am not sure how do you try to add benchmarks, but the ones here are obviously working. You just need to add a dependency on module a appropriate benchmark suite.

therealansh · 2021-06-08T05:58:11Z

I am not sure how do you try to add benchmarks, but the ones here are obviously working. You just need to add a dependency on module a appropriate benchmark suite.

I am trying to run these with JMH but i guess there is an issue with JMH and Kotlin.

altavir · 2021-06-08T07:28:39Z

Are you saying that gradle benchmark task is failing? If it is, please create an issue with the description of the problem. The warning you described earlier is not the case of the problem.

therealansh · 2021-06-08T08:09:31Z

@altavir i guess the issue is related to this plugin i guess artyushov/idea-jmh-plugin#22

altavir · 2021-06-08T08:24:02Z

Nobody talked about idea plugin. Just run benchmarks from gradle. Please see how it is done for other benchmarks.

therealansh · 2021-06-08T08:54:44Z

Nobody talked about idea plugin. Just run benchmarks from gradle. Please see how it is done for other benchmarks.

I did the run the gradle and build the benchmarks but how can i see the results of the benchmarks?

altavir · 2021-06-08T08:58:48Z

In the terminal. Additional documentation is available in the plugin repository.

therealansh · 2021-06-08T10:14:02Z

On running gradle benchmarks it just build but doesnt show any benchmarks of the any of the pre-built benchmark classes (BigIntBenchmark, ArrayBrnchmark and so on) do i have to run any other command as well?

altavir · 2021-06-08T11:42:16Z

therealansh · 2021-06-08T13:52:35Z

Hey @altavir i added some benchmarks do i need to reflect in Readme as well?

altavir · 2021-06-08T13:55:30Z

It would be nice to have the results. In the module readme.

altavir · 2021-06-11T06:51:38Z

@therealansh last two thigs before merge:

resolve conflicts
Add regular Kotlin.math operation to benchmarks for comparison.

therealansh · 2021-06-12T04:33:29Z

@therealansh last two thigs before merge:

resolve conflicts

Add regular Kotlin.math operation to benchmarks for comparison.

Regarding the conflicts as i said should those basic arithmetic functions be removed? In my opinion they do not serve any purpose when we are comparing the libraries.

altavir · 2021-06-12T07:26:34Z

The benchmark shows that the core kotlin math is actually faster than jafama. But we will merge it nonetheless because it is a good example of a new module.

therealansh · 2021-06-12T08:14:35Z

Is it plausible that jafama might perform better on relatively smaller numbers?

therealansh force-pushed the kmathJafama branch from a748745 to 887dfe3 Compare June 2, 2021 19:50

CommanderTvis requested changes Jun 2, 2021

View reviewed changes

CommanderTvis added this to the 0.3 milestone Jun 2, 2021

CommanderTvis self-assigned this Jun 2, 2021

CommanderTvis added feature A new feature request performance Performance optimization issue labels Jun 2, 2021

CommanderTvis added this to In Progress in Algebra via automation Jun 2, 2021

CommanderTvis reviewed Jun 2, 2021

View reviewed changes

kmath-jafama/build.gradle.kts Outdated Show resolved Hide resolved

therealansh requested a review from CommanderTvis June 2, 2021 20:08

CommanderTvis previously requested changes Jun 2, 2021

View reviewed changes

kmath-jafama/src/main/kotlin/space/kscience/kmath/jafama/KMathJafama.kt Outdated Show resolved Hide resolved

kmath-jafama/src/main/kotlin/space/kscience/kmath/jafama/KMathJafama.kt Outdated Show resolved Hide resolved

therealansh force-pushed the kmathJafama branch from 9a810f9 to 5a5f79a Compare June 5, 2021 05:55

altavir requested changes Jun 6, 2021

View reviewed changes

CommanderTvis removed their assignment Jun 7, 2021

therealansh force-pushed the kmathJafama branch from 22f5258 to f27b1c2 Compare June 8, 2021 13:51

therealansh added 7 commits June 12, 2021 10:05

integrate: Jafama + KMath

2dff15c

chore: refactored and dependency add

6c815ab

add: Double using StrictMath

abb3d9f

add: example and Readme

590910a

add: benchmarks for Jafama

9a9ebc7

add:benchmarks to readme

b99d0b9

add: kotlin math benchmarks

03be37b

therealansh force-pushed the kmathJafama branch from 032c0fc to 03be37b Compare June 12, 2021 04:37

altavir approved these changes Jun 12, 2021

View reviewed changes

altavir merged commit c1b105d into SciProgCentre:dev Jun 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

integrate: Jafama + KMath #357

integrate: Jafama + KMath #357

therealansh commented Jun 2, 2021

altavir commented Jun 3, 2021

altavir commented Jun 3, 2021

therealansh commented Jun 3, 2021

CommanderTvis commented Jun 3, 2021

therealansh commented Jun 4, 2021

CommanderTvis commented Jun 4, 2021

CommanderTvis commented Jun 5, 2021

altavir left a comment

altavir Jun 6, 2021

therealansh Jun 6, 2021

altavir Jun 6, 2021

therealansh commented Jun 6, 2021

altavir commented Jun 6, 2021

altavir commented Jun 7, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

altavir commented Jun 11, 2021

therealansh commented Jun 12, 2021

altavir commented Jun 12, 2021

therealansh commented Jun 12, 2021


		public override inline fun norm(arg: Double): Double = FastMath.abs(arg)

		public override inline fun Double.unaryMinus(): Double = -this

integrate: Jafama + KMath #357

integrate: Jafama + KMath #357

Conversation

therealansh commented Jun 2, 2021

altavir commented Jun 3, 2021

altavir commented Jun 3, 2021

therealansh commented Jun 3, 2021

CommanderTvis commented Jun 3, 2021

therealansh commented Jun 4, 2021

CommanderTvis commented Jun 4, 2021

CommanderTvis commented Jun 5, 2021

altavir left a comment

Choose a reason for hiding this comment

altavir Jun 6, 2021

Choose a reason for hiding this comment

therealansh Jun 6, 2021

Choose a reason for hiding this comment

altavir Jun 6, 2021

Choose a reason for hiding this comment

therealansh commented Jun 6, 2021

altavir commented Jun 6, 2021

altavir commented Jun 7, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

therealansh commented Jun 8, 2021

altavir commented Jun 8, 2021

altavir commented Jun 11, 2021

therealansh commented Jun 12, 2021

altavir commented Jun 12, 2021

therealansh commented Jun 12, 2021