Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pushUpdates & pullUpdates Do Not Work in a Docker Container #84

Open
alonalbert opened this issue Aug 27, 2021 · 4 comments
Open

pushUpdates & pullUpdates Do Not Work in a Docker Container #84

alonalbert opened this issue Aug 27, 2021 · 4 comments
Assignees
Labels
feature New feature or request

Comments

@alonalbert
Copy link

More specifically, they do not work unless the container is running in host network mode.

The problem seems to be that the PlotlyServer baseUrl is using a hostname that is internal to the docker container but the value is being passed to the JavaScript which is running in an external network.

@altavir
Copy link
Member

altavir commented Aug 28, 2021

Indeed, the Url is resolved from the request. I will add a custom property to PlotlyServer, which will allow to set it up manually.

@altavir
Copy link
Member

altavir commented Aug 28, 2021

@alonalbert I've pushed a commit that possibly addresses the issue. It allows setting override host and port (not for Jupyter). If you can check it, please let me know.

@alonalbert
Copy link
Author

alonalbert commented Aug 28, 2021 via email

@altavir
Copy link
Member

altavir commented Aug 28, 2021

It is not static.

Look at the code here: https://github.com/mipt-npm/plotly.kt/blob/5980ffd7abddcb0a273a644d77ad69d517b01201/plotlykt-server/src/main/kotlin/space/kscience/plotly/server/PlotlyServer.kt#L187-L193

It takes the URI from the request and then transforms it. So the actual address embedded in the page is depending on where the page has been requested from. I am just not sure, how it will work with multiple interfaces. Your suggestions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants