Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDA] Uses CDF_ISTP as default #101

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Oct 20, 2023

No description provided.

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@jeandet jeandet added the enhancement New feature or request label Oct 20, 2023
@jeandet
Copy link
Member Author

jeandet commented Oct 20, 2023

@brenard-irap the CI issue looks legit, with CDF output format it looks like I get a single column name for a 2 columns variable:

In [1]: from speasy import amda

In [2]: first_param_index=amda.list_parameters()[0]

In [3]: print(first_param_index)
<ParameterIndex: He flux>

In [4]: first_param=amda.get_parameter(first_param_index, "2018-01-01", "2018-01-02T01")

In [5]: first_param
Out[5]: <speasy.products.variable.SpeasyVariable at 0x7f894d4698c0>

In [6]: first_param.columns
Out[6]: ['He flux']

In [7]: first_param.values
Out[7]: 
array([[0.12428   , 0.        ],
...

Looks like an issue on ADMA side?

@jeandet jeandet added this to the 1.2.0 milestone Oct 20, 2023
@brenard-irap
Copy link

For a spectrogram, we don't need to define a label for each data component...

I think you have the same problem with this CDAWeb parameter

>>> import speasy as spz
>>> mms1_dis_energyspectr_omni_fast = spz.get_data(
...     spz.inventories.tree.cda.MMS.MMS1.DIS.MMS1_FPI_FAST_L2_DIS_MOMS.mms1_dis_energyspectr_omni_fast, "2019-01-02T15:30",
...     "2019-01-02T20")
>>> mms1_dis_energyspectr_omni_fast.columns
['DEF_omni']
>>> mms1_dis_energyspectr_omni_fast.values
array([[  88873.6015625 ,   52076.25390625,   67580.1484375 , ...,
         952113.375     , 1113830.75      , 1006203.8125    ],
       [  67058.828125  ,   34980.6015625 ,   45100.02734375, ...,
         971669.5625    , 1124289.375     , 1000310.0625    ],
       [  65529.484375  ,   54712.4765625 ,   49212.6015625 , ...,
         976081.75      , 1111816.125     , 1066082.375     ],
       ...,
       [  24619.7265625 ,       0.        ,       0.        , ...,
         478687.3125    ,  199476.578125  ,  101960.5078125 ],
       [      0.        ,       0.        ,    1759.7244873 , ...,
         523574.90625   ,  278838.625     ,   79713.8203125 ],
       [      0.        ,       0.        ,   14445.49511719, ...,
         410759.90625   ,  193136.21875   ,   81875.1953125 ]])

@jeandet
Copy link
Member Author

jeandet commented Oct 23, 2023

@brenard-irap my bad I overlooked, since there was only two columns I thought that is was a simple timeserie.

AMDA provides different column names between CDF and CSV format

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (476008b) 86.50% compared to head (8bc4b4f) 86.43%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   86.50%   86.43%   -0.07%     
==========================================
  Files          51       51              
  Lines        3045     3045              
  Branches      490      490              
==========================================
- Hits         2634     2632       -2     
- Misses        275      276       +1     
- Partials      136      137       +1     
Flag Coverage Δ
unittests 85.77% <ø> (-0.69%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
speasy/config/__init__.py 95.58% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeandet jeandet merged commit 3e3fcce into SciQLop:main Oct 24, 2023
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants