Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme improvments #104

Merged
merged 4 commits into from Oct 31, 2023
Merged

Readme improvments #104

merged 4 commits into from Oct 31, 2023

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Oct 26, 2023

The idea is to have a more appealing README for the next release.

@jeandet jeandet force-pushed the readme_improvments branch 2 times, most recently from 5504605 to 606ebac Compare October 26, 2023 16:24
@jeandet jeandet marked this pull request as draft October 26, 2023 16:29
@jeandet jeandet added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0cf40a0) 87.27% compared to head (3af68e5) 87.28%.

❗ Current head 3af68e5 differs from pull request most recent head 0e44ce9. Consider uploading reports for the commit 0e44ce9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #104   +/-   ##
=======================================
  Coverage   87.27%   87.28%           
=======================================
  Files          51       51           
  Lines        3050     3052    +2     
  Branches      495      495           
=======================================
+ Hits         2662     2664    +2     
  Misses        251      251           
  Partials      137      137           
Flag Coverage Δ
unittests 86.63% <87.50%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
speasy/plotting/mpl_backend/__init__.py 84.09% <87.50%> (+0.75%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeandet
Copy link
Member Author

jeandet commented Oct 27, 2023

@cmoissar, @vgenot do you have any notebooks we could add to the Speasy gallery :) ?
That would be nice to add some more realistic use-cases here https://speasy.readthedocs.io/en/latest/examples/index.html.

@cmoissar
Copy link
Contributor

cmoissar commented Oct 27, 2023 via email

@jeandet jeandet force-pushed the readme_improvments branch 2 times, most recently from caf49f1 to b7f90e7 Compare October 27, 2023 16:38
a bit more colormap plots tuning

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@jeandet jeandet marked this pull request as ready for review October 30, 2023 10:23
@jeandet
Copy link
Member Author

jeandet commented Oct 30, 2023

@nicolasaunai you can check the readme for the wording as we discussed about the introduction that was not user friendly.
@brenard-irap if you can review examples notebooks with @vgenot and also the new readme that would be awesome.

@nicolasaunai nicolasaunai mentioned this pull request Oct 30, 2023
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@jeandet jeandet merged commit 6caade9 into SciQLop:main Oct 31, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants