Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop LegacyVersion usage, fixes #78 #79

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Dec 11, 2022

No description provided.

@jeandet jeandet added the bug Something isn't working label Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Base: 84.47% // Head: 83.24% // Decreases project coverage by -1.23% ⚠️

Coverage data is based on head (42d37d8) compared to base (9d94a0f).
Patch coverage: 84.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   84.47%   83.24%   -1.24%     
==========================================
  Files          44       44              
  Lines        2673     2679       +6     
  Branches      404      404              
==========================================
- Hits         2258     2230      -28     
- Misses        292      321      +29     
- Partials      123      128       +5     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
speasy/core/cache/version.py 91.30% <84.61%> (-8.70%) ⬇️
...asy/webservices/cda/_inventory_builder/__init__.py 81.48% <0.00%> (-12.97%) ⬇️
speasy/webservices/amda/_impl.py 67.28% <0.00%> (-10.29%) ⬇️
speasy/webservices/ssc/__init__.py 81.01% <0.00%> (-10.13%) ⬇️
speasy/webservices/amda/rest_client.py 75.25% <0.00%> (-3.10%) ⬇️
speasy/core/proxy/__init__.py 81.44% <0.00%> (-2.07%) ⬇️
speasy/webservices/amda/ws.py 84.93% <0.00%> (-0.69%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

speasy/core/cache/version.py Fixed Show fixed Hide fixed
speasy/core/cache/version.py Fixed Show fixed Hide fixed
speasy/core/cache/version.py Fixed Show fixed Hide fixed
speasy/core/cache/version.py Fixed Show fixed Hide fixed
@jeandet jeandet marked this pull request as ready for review December 13, 2022 09:39
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@jeandet jeandet merged commit f11b4c9 into SciQLop:main Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant