Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check all the iruby examples and a minor change in a CSS example in HighCharts #121

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

Prakriti-nith
Copy link
Contributor

Run-all all the IRuby examples to ensure that nothing is breaking.

@coveralls
Copy link

coveralls commented Aug 15, 2018

Pull Request Test Coverage Report for Build 679

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.044%

Totals Coverage Status
Change from base Build 677: 0.0%
Covered Lines: 3208
Relevant Lines: 3272

💛 - Coveralls

@Shekharrajak
Copy link
Member

Note : Has to finish before new release : #123

@Prakriti-nith
Copy link
Contributor Author

I just did a minor change in the CSS examples in this PR and re-run all the examples again. I think this is complete.

@Shekharrajak
Copy link
Member

I just did a minor change in the CSS examples in this PR

I didn't see new commit @Prakriti-nith . Are that changes just for you?

@Prakriti-nith
Copy link
Contributor Author

@Shekharrajak I did the change in the original commit of the PR. While moving the CSS, modules and chart_class options to the third parameter, I forgot to do the same in one of the examples of CSS, I have corrected that in this PR.

@Shekharrajak
Copy link
Member

Thanks @Prakriti-nith , for update. After #119 we will merge this.

@Shekharrajak
Copy link
Member

@Prakriti-nith , is it good to merge ?

@Prakriti-nith
Copy link
Contributor Author

@Shekharrajak Yes, it can be merged.

@Shekharrajak Shekharrajak merged commit beb67b6 into SciRuby:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants