-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and Default RichContent for UI Rendering Purpose #195
Conversation
public string? Payload { get; set; } | ||
[JsonPropertyName("image_url")] | ||
public string? ImageUrl { get; set; } | ||
public string? PostBackUrl { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add [JsonPropertyName("postback_url")]
?
{ | ||
public class Recipient | ||
{ | ||
public string? Id { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Id
shouldn't be nullable.
{ | ||
public class RichContent<T> | ||
{ | ||
public Recipient? Recipient { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recipient
should be required.
/// RESPONSE | ||
/// </summary> | ||
[JsonPropertyName("messaging_type")] | ||
public string? MessageingType { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is typo, and it's not nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can set it as a fixed value messaging_type="RESPONSE"
currently.
|
||
namespace BotSharp.Abstraction.Messaging.Models.RichContent | ||
{ | ||
public class SenderActionModel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename it to SenderActionMessage
?
{ | ||
public string? Type { get; set; } | ||
public string? Url { get; set; } | ||
public string? Title { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Type
and Title
should be required.
{ | ||
public class CommonTemplate<T> | ||
{ | ||
public string TemplateType { get; set; } = string.Empty; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[JsonPropertyName("template_type")]
{ | ||
public class TextMessage | ||
{ | ||
public string? Text { get; set; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not nullable.
No description provided.