Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #74

Merged
merged 8 commits into from
Aug 5, 2023
Merged

Conversation

martindevans
Copy link
Member

@martindevans martindevans commented Jul 30, 2023

Added some simple CI which builds the project and runs tests in debug and release mode on Linux, Windows and MacOS.

I've added an action to download a model into the test project as part of the build. This file is not comitted to the repo, but it's cached in the CI so it should be fast after the first time.

This also incorporates a fix to the netstandard2.0 build (formerly #73) so that the CI doesn't immediately fail!

@martindevans
Copy link
Member Author

I've added a single test which simply loads and disposes a model (previously there were no tests). I'm not sure why this is failing on Linux and MacOS, probably an issue with the way the test project was set up but I'm not sure what.

@martindevans
Copy link
Member Author

Someone on Discord (jlsantiago) did some investigation into why this is failing on Mac. No conclusion yet.

Here's the conversation for reference: https://discord.com/channels/1106946823282761851/1106947264938790972/1137050602711560252

@saddam213
Copy link
Collaborator

saddam213 commented Aug 5, 2023

It looks like there was some issues Marshaling the tensor_split affecting Linux and Mac

I have commited a fix 2b5efa0 that should work on all platforms, can confirm Winows and Linux, but I dont have a recent compilation of the Mac lib to test

However 99% sure this will also work for mac also

EDIT: Actions now successful for Linux
https://github.com/saddam213/LLamaSharp/actions/runs/5769657251

@martindevans
Copy link
Member Author

martindevans commented Aug 5, 2023

@saddam213 thanks for investigating this 👍

Would you mind opening a PR into my fork for this fix?

@saddam213
Copy link
Collaborator

I think this branch predates the tensor_split change in llama.cpp

@martindevans
Copy link
Member Author

martindevans commented Aug 5, 2023

I think this branch predates the tensor_split change in llama.cpp

@saddam213 I've rebased this branch onto master, so it should be fully up to date now.

Note: this has broken the CI on Windows, since the DLLs are out of date right now

@martindevans
Copy link
Member Author

I'm going to merge this PR and the MacOS binaries update by @SignalRT (#77). After that we'll have CI running and we can see what the status is with cross platform support and binary versions etc.

@martindevans martindevans merged commit b2ef8e6 into SciSharp:master Aug 5, 2023
0 of 6 checks passed
@martindevans martindevans deleted the github_actions branch August 5, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants