Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn NumPy to static class #155

Closed
Oceania2018 opened this issue Dec 13, 2018 · 3 comments
Closed

Turn NumPy to static class #155

Oceania2018 opened this issue Dec 13, 2018 · 3 comments
Assignees
@Oceania2018
Labels
enhancement New feature or request

Comments

@Oceania2018
Copy link
Member

Oceania2018 commented Dec 13, 2018 •
edited

I think we should turn the NumPy class to be static.
It will look like below:

using np = NumSharp.Core.NumPy;

@dotChris90 , @fdncred What do you guys think?
@Oceania2018 Oceania2018 self-assigned this Dec 13, 2018
@Oceania2018 Oceania2018 added the enhancement New feature or request label Dec 13, 2018
@dotChris90
Copy link
Member

dotChris90 commented Dec 13, 2018 •
edited

I think you are right. before we had generic and it so we need multiple instances.

But since ndarrays now not generics.... I think there is no reason for keep it so static is fine

Oceania2018 added a commit that referenced this issue Dec 13, 2018
@Oceania2018
Turn NumPy to static class #155
e3a8b07
@Oceania2018
Copy link
Member Author

Hooray, be more like numpy.

@fdncred
Copy link
Contributor

fdncred commented Dec 13, 2018

works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Oceania2018 Oceania2018

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fdncred @Oceania2018 @dotChris90