Added: complex, real, imag, angle #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oceania2018
reviewed
Mar 26, 2023
| @@ -0,0 +1,26 @@ | |||
| /***************************************************************************** | |||
| Copyright 2018 The TensorFlow.NET Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
Is it better to change to 2023 {Your Name}
There was a problem hiding this comment.
I have moved "complex" to tf.math.cs. I think, it will be more in line with the other code structure. The reason why I created it as a separate file was - I uses "exp" as an example. I would suggest moving "exp" inside of tf.math.cs too.
There was a problem hiding this comment.
Please let me know if anything else needs to be changed before the pull request will be pulled. I have a plan to work on adding tf.signal fft support, but I need complex numbers support to be in the repository first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added basic missing functionality for complex numbers. Unfortunately, only complex64 is fully functional, complex128 needs more work which I do not know how to do. Please merge or let me now what needs to be adjusted.