New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for 204: Find MCC feature from the subgraphs found #205
Conversation
@@ -50,6 +50,14 @@ object MCSApp extends App { | |||
val minAreaThres = 16 | |||
val minGraphLength = 4 | |||
|
|||
/** Criteria for MCC */ | |||
val minFeatureLength = 6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the purposes of not adding another dataset to test, make this length 5 instead of 6.
nodeAreaCriteriaB += 1 | ||
} | ||
} | ||
if (nodeAreaCriteriaA >= areaCriteriaA || nodeAreaCriteriaB >= areaCriteriaB) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if statement should be
if (nodeAreaCriteriaA >= areaCriteriaA && nodeAreaCriteriaB >= areaCriteriaB)
edgesTupleList | ||
}) | ||
return textfiles | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
combining sets with overlapping nodes to make one set is required.
For e.g. running with another dataset, the following was output:
Set(2009083120:18, 2009083117:16, 2009083123:26, 2009083118:11, 2009083119:16, 2009083122:22, 2009083121:9)Set(2009083117:16, 2009083112:15, 2009083116:19, 2009083113:22, 2009083115:14, 2009083114:16)
The node 2009083117:16 repeats in both sets, thus linking the two, and the MCC should really be the combination of these two.
* @param sc | ||
* @return | ||
*/ | ||
def loadSubgraphsFromFile(filepath: String, sc: SparkContext): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method should be in MCSOps.
Addressed the logical error and the fix for the MCSApp in PR #212 |
Scispark 204 fixes on PR #205
No description provided.