Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify custom function signature generation for state transitions to change argument name "data" to name of event #5

Open
matthewadams opened this issue Nov 22, 2016 · 1 comment

Comments

@matthewadams
Copy link
Contributor

From @gacord23 on September 14, 2016 16:14

This is purely a usability issue.

Given state transition
receives custom checkIn becomes waitingForAssistance sends checkedIn
the generator creates custom function signature
function(causedByEventName,meta,data,done)

Since the term data wasn't meaningful to me, I inadvertently overwrote it in my custom routine. Had the generator used the event name checkIn instead of data, like
function(causedByEventName,meta,checkIn,done)
it may have made things more obvious.

Copied from original issue: SciSpike/yaktor-dsl-xtext#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant