Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pcolormesh patched? #992

Closed
corinnebosley opened this issue Jan 4, 2018 · 1 comment
Closed

Remove pcolormesh patched? #992

corinnebosley opened this issue Jan 4, 2018 · 1 comment
Labels
Experience-needed: low SemVer: patch Type: Documentation
Milestone
0.17.0

Comments

@corinnebosley
Copy link
Member

This is what the docstring for cartopy.mpl.geoaxes.GeoAxes._pcolormesh_patched says:

A temporary, modified duplicate of
:func:`~matplotlib.pyplot.pcolormesh'.

This function contains a workaround for a Matplotlib issue
and will be removed once the issue has been resolved.
https://github.com/matplotlib/matplotlib/pull/1314

That link says that the PR was merged 5 years ago. Surely we can take this out now?
@pelson
Copy link
Member

pelson commented Jan 4, 2018

Unfortunately it has moved on since then. I don't think we will ever be able to reconcile the two...

See also: https://github.com/SciTools/cartopy/blob/master/lib/cartopy/mpl/geoaxes.py#L1462-L1480

Perhaps we should just remove the comment.

QuLogic added a commit to QuLogic/cartopy that referenced this issue Nov 8, 2018
@QuLogic
DOC: Remove old information in docstring.
6d3c718 
_pcolormesh_patched is no longer used as a workaround for anything.

Closes SciTools#992.
@QuLogic QuLogic added this to the 0.17 milestone Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Experience-needed: low SemVer: patch Type: Documentation
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
3 participants
@QuLogic @pelson @corinnebosley