Add support for Equidistant Conic projection. #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Feb 9, 2018
docs/make_projection.py
Outdated
| @@ -42,7 +42,8 @@ | |||
| PRJ_SORT_ORDER = {'PlateCarree': 1, | |||
| 'Mercator': 2, 'Mollweide': 2, 'Robinson': 2, | |||
| 'TransverseMercator': 2, 'LambertCylindrical': 2, | |||
| 'LambertConformal': 2, 'Stereographic': 2, 'Miller': 2, | |||
| 'LambertConformal': 2, 'EquidistantConic':2, | |||
pelson
reviewed
Feb 21, 2018
pelson
reviewed
Feb 21, 2018
lib/cartopy/crs.py
Outdated
| false_easting=0.0, false_northing=0.0, | ||
| standard_parallels=(20.0, 50.0), globe=None): | ||
| """ | ||
| Kwargs: |
There was a problem hiding this comment.
Not really your fault, but the docstring format has been updated since this branch was created.
See https://github.com/SciTools/cartopy/pull/998/files#diff-6dfcada343269e6678a777c4f9a5223d for reference.
pelson
reviewed
Feb 21, 2018
| @@ -0,0 +1,137 @@ | |||
| # (C) British Crown Copyright 2015 - 2018, Met Office | |||
|
@strezen I'm looking to try to clear out the last few things that were milestones 0.17. Can you rebase on current master and see if that fixes up the tests (at least Travis)? |
Implement support for Equidistant Conic along with tests from Snyder's book.
It needs the same central longitude wraparound fix as other projections.
|
Thanks @strezen! I took the liberty of rebasing this and fixing up things to match the current standard as well as support for Proj>=5. PTAL @dopplershift. |
dopplershift
approved these changes
Oct 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement support for Equidistant Conic projection along with the related tests with data
taken from Snyder's book.