Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

force string conversion for wmts row, col and tile set id #1052

Merged
merged 1 commit into from
May 16, 2018
Merged

force string conversion for wmts row, col and tile set id #1052

merged 1 commit into from
May 16, 2018

Conversation

acrosby
Copy link
Contributor

@acrosby acrosby commented Mar 16, 2018 •
edited
Loading

Rationale

Fix for owslib wmts get tiles action error coming from row, col as int rather than str which seems to work.

Implications

This should probably also be fixed in https://github.com/geopython/OWSLib, but we can protect ourselves from these errors here if they won't be handled in owslib. Found this issue when trying to use external WMTS sources, related to Issue #1049

@SciTools-assistant SciTools-assistant added the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Mar 16, 2018
@SciTools-assistant SciTools-assistant removed Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form labels Apr 26, 2018
pelson
pelson approved these changes Apr 26, 2018
View reviewed changes
Copy link
Member

@pelson pelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @acrosby.
Would you mind feeding this back up to owslib and cross-linking. Makes sense for this to be handled on their end too.

@acrosby
Copy link
Contributor Author

acrosby commented Apr 26, 2018

Sure, I will open an issue and link back.

@acrosby acrosby mentioned this pull request Apr 30, 2018
Closed
@pelson pelson merged commit d07edb5 into SciTools:master May 16, 2018
@pelson pelson added this to the 0.17 milestone May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pelson pelson pelson approved these changes

Assignees
No one assigned
Labels
SemVer: patch Type: Bug
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@acrosby @pelson @SciTools-assistant