Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add epsg 3857 support to wmts #1053

Merged
merged 1 commit into from
Oct 27, 2018
Merged

add epsg 3857 support to wmts #1053

merged 1 commit into from
Oct 27, 2018

Conversation

acrosby
Copy link
Contributor

@acrosby acrosby commented Mar 16, 2018

Rationale

Support external WMTS sources that use EPSG 3857 Google Maps/Pseudo-Mercator projections. This includes ESRI basemaps and other commercial vendor sources. Attempt to address Issue #1049

Implications

This should only allow additional urn projection string matches to the existing crs.GOOGLE_MERCATOR projection using a commonly found EPSG code.

@SciTools-assistant SciTools-assistant added the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Mar 16, 2018
Copy link
Member

@pelson pelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Would like to find a solid form for epsg referencing - the approach already taken in cartopy is clearly not a long-term scalable solution, but should be made simpler by cartopy<>proj4 definition conversion.

@SciTools-assistant SciTools-assistant removed the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Apr 26, 2018
@pelson
Copy link
Member

pelson commented Apr 26, 2018

FWIW, #924 also has opinions about epsg:3857 (though in a more general sense than WMTS).

@acrosby
Copy link
Contributor Author

acrosby commented Oct 26, 2018

Just rebased against the master (I think), any movement in getting this in a release?

@QuLogic QuLogic added this to the 0.17 milestone Oct 27, 2018
@QuLogic QuLogic merged commit e39ed28 into SciTools:master Oct 27, 2018
@QuLogic
Copy link
Member

QuLogic commented Oct 27, 2018

Thanks @acrosby!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants